Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the mount path for vip-config to ABSPATH/vip-config to match production #2124

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

rinatkhaziev
Copy link
Contributor

Description

For legacy reasons we were loading vip-config.php from /wp/wp-content/vip-config.php. This broke sunrise loader because it was expected to be loaded from ABSPATH . /vip-config/ rather than from WP_CONTENT_DIR . /vip-config/.

We've implemented a fallback loader in the dev env awhile back, so this change shouldn't negatively affect existing environments.

This also bumps DEV_ENVIRONMENT_VERSION to ensure that .lando.yml will be regenerated on startup.

Pull request checklist

New release checklist

Steps to Test

  1. Check out PR.
  2. Run npm run build && npm link
  3. Spin up an environment, add define( 'SUNRISE', true ); to wp-config-defaults.php
  4. Make some changes to /vip-config/client-sunrise.php (like exit)or run a file_exists check fromwp shell`

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Member

@sjinks sjinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only concern is the pre-2023 environments (see Automattic/vip-container-images#516)

@rinatkhaziev rinatkhaziev merged commit 93e36a5 into trunk Nov 26, 2024
16 checks passed
@rinatkhaziev rinatkhaziev deleted the fix/vip-config-mount-path branch November 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants