Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds check for AUTO_INCREMENT attribute in SQL import #2174

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Adds check for AUTO_INCREMENT attribute in SQL import #2174

merged 2 commits into from
Dec 30, 2024

Conversation

iamchughmayank
Copy link
Contributor

@iamchughmayank iamchughmayank commented Dec 26, 2024 •
edited
Loading

Description

This PR adds updates the list of validation checks during SQL import to include the check to validate the presence of AUTO_INCREMENT attribute in the CREATE TABLE statements in the SQL file.

Pull request checklist

New release checklist

Steps to Test

  1. Check out the PR
  2. Run npm run test:e2e:dev-env to test the validation check for AUTO_INCREMENT attribute

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@iamchughmayank iamchughmayank changed the title FORNO-2053: Adds autoIncrement check with requiredCheckFormatter FORNO-2053: Adds check for AUTO_INCREMENT attribute in SQL import Dec 26, 2024
@iamchughmayank iamchughmayank changed the title FORNO-2053: Adds check for AUTO_INCREMENT attribute in SQL import Adds check for AUTO_INCREMENT attribute in SQL import Dec 26, 2024
@iamchughmayank iamchughmayank marked this pull request as ready for review December 26, 2024 20:57
@iamchughmayank iamchughmayank requested a review from a team December 26, 2024 21:00
saroshaga
saroshaga reviewed Dec 27, 2024
View reviewed changes
__fixtures__/dev-env-e2e/fail-autoIncrement-validation.sql Outdated
PRIMARY KEY (`ID`),
UNIQUE KEY `ts_action_instance_status` (`timestamp`,`action`(191),`instance`,`status`),
KEY `status` (`status`)
) ENGINE=InnoDB AUTO_INCREMENT=17 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need extra line here

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@iamchughmayank iamchughmayank merged commit cb240d7 into trunk Dec 30, 2024
17 checks passed
@iamchughmayank iamchughmayank deleted the update/import-auto-increment-check branch December 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjinks sjinks sjinks approved these changes

@saroshaga saroshaga Awaiting requested review from saroshaga

Assignees
No one assigned
Labels
[Status] Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamchughmayank @sjinks @saroshaga