fix(dev-env): remove lando/compose/env
directory when environment is destroyed
#2181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we destroy an environment,
docker compose
files in~/.local/share/vip/lando/compose/<env>
remain. This may cause interesting bugs when an environment with the same name is created later.This PR ensures that the directory is removed when the environment gets destroyed.
Pull request checklist
New release checklist
Steps to Test
vip dev-env create -s test-env < /dev/null
vip dev-env start -s test-env
~/.local/share/vip/lando/compose/testenv
exists and contains.yml
filesvip dev-env destroy -s test-env
~/.local/share/vip/lando/compose/testenv
is gone