chore(deps-dev): Bump automattic/vipwpcs from 2.3.4 to 3.0.0 #4844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
Codecov Report
@@ Coverage Diff @@
## develop #4844 +/- ##
=============================================
- Coverage 29.11% 29.10% -0.01%
Complexity 4705 4705
=============================================
Files 276 276
Lines 20751 20749 -2
=============================================
- Hits 6042 6040 -2
Misses 14709 14709
|
sjinks
force-pushed
the
dependabot/composer/automattic/vipwpcs-3.0.0
branch
from
2765d47 to
935eb19
Compare
GaryJones
reviewed
Sep 7, 2023
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| // phpcs:disable Universal.Files.SeparateFunctionsFromOO.Mixed | |||
There was a problem hiding this comment.
Could the couple of requires and the single function be moved out of the file to maintain consistency with the expectation around classes-only being in a class- file?
There was a problem hiding this comment.
Definitely would be good to get around to removing the suppressions where it makes sense, but doesn't really have to be in this PR that updates the tooling to an important milestone. Can handle it separately in another PR.
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| // phpcs:disable Universal.Files.SeparateFunctionsFromOO.Mixed | |||
There was a problem hiding this comment.
Not sure if this file is copied in from elsewhere, but separating it into a class-only file and a functions file may be the better approach here IMO.
| </rule> | ||
|
|
||
| <rule ref="Universal.Files.SeparateFunctionsFromOO.Mixed"> | ||
| <exclude-pattern>/tests/*</exclude-pattern> |
There was a problem hiding this comment.
How have we managed to get test classes and functions mixed in the same file? Could any fixtures be moved out to their own file?
tests/prometheus-collectors/test-class-potential-multi-dataset-queries-collector.php
Show resolved
Hide resolved
sjinks
force-pushed
the
dependabot/composer/automattic/vipwpcs-3.0.0
branch
from
3cad86f to
c45a73e
Compare
GaryJones
reviewed
Sep 18, 2023
WPprodigy
approved these changes
Sep 20, 2023
Bumps [automattic/vipwpcs](https://github.com/Automattic/VIP-Coding-Standards) from 2.3.4 to 3.0.0. - [Release notes](https://github.com/Automattic/VIP-Coding-Standards/releases) - [Changelog](https://github.com/Automattic/VIP-Coding-Standards/blob/develop/CHANGELOG.md) - [Commits](Automattic/VIP-Coding-Standards@2.3.4...3.0.0) --- updated-dependencies: - dependency-name: automattic/vipwpcs dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
sjinks
force-pushed
the
dependabot/composer/automattic/vipwpcs-3.0.0
branch
from
6685e3e to
f32b951
Compare
github-actions
bot
added
[Status] Deployed to production
and removed
[Status] Deployed to staging
labels
andrea-sdl
pushed a commit
that referenced
this pull request
Oct 19, 2023
* chore(deps-dev): Bump automattic/vipwpcs from 2.3.4 to 3.0.0 Bumps [automattic/vipwpcs](https://github.com/Automattic/VIP-Coding-Standards) from 2.3.4 to 3.0.0. - [Release notes](https://github.com/Automattic/VIP-Coding-Standards/releases) - [Changelog](https://github.com/Automattic/VIP-Coding-Standards/blob/develop/CHANGELOG.md) - [Commits](Automattic/VIP-Coding-Standards@2.3.4...3.0.0) --- updated-dependencies: - dependency-name: automattic/vipwpcs dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * style: fix phpcs issues * fix: address code review comments * fix: new phpcs issues --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Volodymyr Kolesnykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps automattic/vipwpcs from 2.3.4 to 3.0.0.
Release notes
Sourced from automattic/vipwpcs's releases.
Changelog
Sourced from automattic/vipwpcs's changelog.
Commits
1b8960eMerge pull request #793 from Automattic/release/3.0.0fad2290Merge pull request #792 from Automattic/release/3.0.0-changelog1080d563.0.0: Add changelog63e76ecMerge pull request #790 from Automattic/fix/phpunit-schema3e6a27bMerge pull request #791 from Automattic/fix/contributing-doc9146d1cDocs: Update CONTRIBUTING.mdca302d8Merge pull request #789 from Automattic/3.0/fix/666-branch-rename60988b1PHPUnit: Use 7.5 schema2758288Updates related to branch rename from master to main64aa799Merge pull request #788 from Automattic/fix/541-mustache-sub-issue-gb-vs-curliesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)