Don’t close the ES index before updating settings #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only settings we auto-fix are dynamic settings, and we don’t need to close the index first before changing those. Closing/opening an index appears to cause quite a bit of stress on the clusters.
walthowd
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## develop #4858 +/- ##
==========================================
Coverage 29.06% 29.06%
Complexity 4700 4700
==========================================
Files 276 276
Lines 20736 20736
==========================================
Hits 6027 6027
Misses 14709 14709
|
WPprodigy
added a commit
that referenced
this pull request
Sep 12, 2023
The only settings we auto-fix are dynamic settings, and we don’t need to close the index first before changing those. Closing/opening an index appears to cause quite a bit of stress on the clusters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only settings that we auto-fix are dynamic settings, and we don’t need to close the index first before changing those (#, #, #). Closing/opening an index appears to cause quite a bit of stress on the clusters.
This was introduced in #3879. Before that the default was to not $close_first.