Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for VIP_GO_APP_ENVIRONMENT before using it #4889

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Check for VIP_GO_APP_ENVIRONMENT before using it #4889

merged 1 commit into from
Sep 22, 2023

Conversation

srtfisher
Copy link
Contributor

@srtfisher srtfisher commented Sep 22, 2023

Description

Ensure that VIP_GO_APP_ENVIRONMENT is defined before using it. Throws a fatal error when using in a CI environment where VIP_GO_APP_ENVIRONMENT is not defined but we are using https://github.com/Automattic/vip-go-mu-plugins/blob/develop/drop-ins/object-cache.php as our object-cache.php file.

Ensures that VIP_USE_NEXT_OBJECT_CACHE_DROPIN is still set to false for non-VIP_GO_APP_ENVIRONMENT environments.

Changelog Description

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@srtfisher srtfisher requested a review from a team as a code owner September 22, 2023 15:37
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #4889 (5437bf0) into develop (7e18e0a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4889   +/-   ##
==========================================
  Coverage      29.12%   29.12%           
  Complexity      4704     4704           
==========================================
  Files            276      276           
  Lines          20751    20751           
==========================================
  Hits            6044     6044           
  Misses         14707    14707           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants