Check for VIP_GO_APP_ENVIRONMENT before using it #4889
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that
VIP_GO_APP_ENVIRONMENT
is defined before using it. Throws a fatal error when using in a CI environment whereVIP_GO_APP_ENVIRONMENT
is not defined but we are using https://github.com/Automattic/vip-go-mu-plugins/blob/develop/drop-ins/object-cache.php as ourobject-cache.php
file.Ensures that
VIP_USE_NEXT_OBJECT_CACHE_DROPIN
is still set tofalse
for non-VIP_GO_APP_ENVIRONMENT
environments.Changelog Description
Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test