Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CANTINA-948 (ElasticPress): Add missing properties for Indexable and Block class #4905

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

rebeccahum
Copy link
Contributor

Description

Fixes the PHP 8.2 errors:

Creation of dynamic property ElasticPress\Indexable\Post\Post::$labels
Creation of dynamic property ElasticPress\Feature\Facets\Block::$renderer

Changelog Description

Plugin Updated: Enterprise Search

Add missing properties for Indexable and Block class

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review September 27, 2023 19:47
@rebeccahum rebeccahum requested a review from a team as a code owner September 27, 2023 19:47
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4905 (86f6e63) into develop (463749c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4905   +/-   ##
==========================================
  Coverage      29.22%   29.22%           
  Complexity      4723     4723           
==========================================
  Files            277      277           
  Lines          20816    20816           
==========================================
  Hits            6083     6083           
  Misses         14733    14733           

@rebeccahum rebeccahum merged commit 73d9dc1 into develop Sep 27, 2023
42 checks passed
@rebeccahum rebeccahum deleted the php-8.2/fix-ep-dynamic-properties branch September 27, 2023 20:16
@rebeccahum rebeccahum added the [Component] Search ChangelogTagID: 2373 label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants