Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search e2e Tests: Fix b0rked WooCommerce test #4906

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Sep 27, 2023

Description

Looks like a WooCommerce update added some extra queries, so we need to take that into account in the tests and check the third one. Follows up on https://github.com/Automattic/vip-go-mu-plugins/pull/4729/files#r1279557202.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4906 (13d0441) into develop (73d9dc1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4906   +/-   ##
==========================================
  Coverage      29.22%   29.22%           
  Complexity      4723     4723           
==========================================
  Files            277      277           
  Lines          20816    20816           
==========================================
  Hits            6083     6083           
  Misses         14733    14733           

@rebeccahum rebeccahum marked this pull request as ready for review September 28, 2023 01:36
@rebeccahum rebeccahum requested a review from a team as a code owner September 28, 2023 01:36
@sjinks
Copy link
Member

sjinks commented Sep 28, 2023

Thank you!

@sjinks sjinks merged commit d4acfcc into develop Sep 28, 2023
44 checks passed
@sjinks sjinks deleted the tests/fix-search-e2e-woo branch September 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants