CANTINA-958: Add better filtering in wp vip two-factor report CLI command

[rebeccahum]

Description

Adds filtering by whether 2fa is enabled, 2fa provider, user role, and user.

Example usages:
* wp vip two-factor report
* wp vip two-factor report --2fa-enabled=true
* wp vip two-factor report --2fa-provider=email
* wp vip two-factor report --role=administrator
* wp vip two-factor report --role=administrator --2fa-enabled=false
* wp vip two-factor report --role=administrator --2fa-enabled=true --2fa-provider=email
* wp vip two-factor report --user_login=wpvip

Changelog Description

WP-CLI Command Updated: wp vip two-factor report

Add filtering by whether 2fa is enabled, 2fa provider, user role, and user.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally (or has an appropriate fallback).
• This change works and has been tested on a Go sandbox.
• This change has relevant unit tests (if applicable).
• This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

1. Create users with different roles, administrative users with 2FA and administrative users without 2FA
2. Do the examples in description and ensure it returns the expected results

[codecov]

Codecov Report

Merging #4910 (d56f402) into develop (8de9938) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4910      +/-   ##
=============================================
- Coverage      29.20%   29.14%   -0.07%     
- Complexity      4726     4740      +14     
=============================================
  Files            277      277              
  Lines          20830    20873      +43     
=============================================
  Hits            6083     6083              
- Misses         14747    14790      +43     

Files	Coverage Δ
wp-cli/vip-two-factor.php	0.00% <0.00%> (ø)

[rebeccahum]

@GaryJones Can you plz traumatize me with a code review thx

[GaryJones]

A couple of minor bits, but overall ✅

Would be good to add some Behat tests to check the guard clauses you have in here, as well successful output. (example)

Do you have any thoughts about getting this into https://github.com/WordPress/two-factor instead?

[GaryJones]

Suggested change

	$fields = array( 'ID', 'display_name', 'roles' );
	$fields[] = 'two_factor_enabled';
	$fields[] = 'two_factor_providers';
	$fields = array( 'ID', 'display_name', 'roles', 'two_factor_enabled', 'two_factor_providers' );

Further, looking at the output from wp user list --format=table:

+----+------------------+-------------------+-----------------------------------------+---------------------+---------------+
| ID | user_login       | display_name      | user_email                              | user_registered     | roles         |
+----+------------------+-------------------+-----------------------------------------+---------------------+---------------+

...then maybe this report output should also include the user_login, after the ID?
(May be outside the scope of this PR)

[rebeccahum]

Nah, I don't think it's necessary given the user lookup can be login/id/email.