Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http-concat to include PHP 8.0+ fixes #4919

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

rebeccahum
Copy link
Contributor

Description

Pulls in Automattic/nginx-http-concat#72

Changelog Description

Plugin Updated: http-concat

We upgraded http-concat to include the PHP 8.1 fix Automattic/nginx-http-concat#72

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

@rebeccahum rebeccahum marked this pull request as ready for review October 4, 2023 18:39
@rebeccahum rebeccahum requested a review from a team as a code owner October 4, 2023 18:39
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #4919 (2722c42) into develop (280f1c3) will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4919      +/-   ##
=============================================
+ Coverage      29.12%   29.17%   +0.04%     
  Complexity      4744     4744              
=============================================
  Files            278      278              
  Lines          20887    20887              
=============================================
+ Hits            6083     6093      +10     
+ Misses         14804    14794      -10     

see 7 files with indirect coverage changes

@WPprodigy WPprodigy merged commit c0b3a23 into develop Oct 9, 2023
42 checks passed
@WPprodigy WPprodigy deleted the update/http-concat branch October 9, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants