-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add potential multi-dataset logger #4920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4920 +/- ##
=============================================
+ Coverage 29.12% 29.22% +0.10%
- Complexity 4744 4748 +4
=============================================
Files 278 278
Lines 20887 20905 +18
=============================================
+ Hits 6083 6110 +27
+ Misses 14804 14795 -9
|
mjangda
requested changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some notes.
prometheus-collectors/class-potential-multi-dataset-queries-collector.php
Outdated
Show resolved
Hide resolved
prometheus-collectors/class-potential-multi-dataset-queries-collector.php
Outdated
Show resolved
Hide resolved
prometheus-collectors/class-potential-multi-dataset-queries-collector.php
Outdated
Show resolved
Hide resolved
prometheus-collectors/class-potential-multi-dataset-queries-collector.php
Show resolved
Hide resolved
…llector.php Co-authored-by: Mohammad Jangda <[email protected]>
mjangda
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
WPprodigy
approved these changes
Oct 5, 2023
github-actions
bot
added
[Status] Deployed to production
and removed
[Status] Deployed to staging
labels
Oct 17, 2023
andrea-sdl
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Add potential multi dataset logger * Sanitize fields * Use esc_url_raw since sanitize_url is deprecated * Update prometheus-collectors/class-potential-multi-dataset-queries-collector.php Co-authored-by: Mohammad Jangda <[email protected]> * Check if log2logstash is defined before calling it --------- Co-authored-by: Mohammad Jangda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a log entry containing the request information and backtrace when a potential multi-dataset query is detected.
Changelog Description
N/A
Pre-review checklist
Pre-deploy checklist
Steps to Test