Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qm-object-cache): fix closing markup for tabs nesting #4928

Merged
merged 1 commit into from
Oct 7, 2023
Merged

fix(qm-object-cache): fix closing markup for tabs nesting #4928

merged 1 commit into from
Oct 7, 2023

Conversation

mae829
Copy link
Contributor

@mae829 mae829 commented Oct 7, 2023

Description

Fix for one of the Query Monitor plugins calling the closing markup at the end of tabs.
The existing code will not call the closing markup if there's no group_stats for object cache causing some of the QM content to not display.

Before and after:
Screenshot 2023-10-06 at 6 24 35 PM
Screenshot 2023-10-06 at 6 25 45 PM

Changelog Description

Fix broken markup call in Query Monitor plugin for object cache.

Fix broken markup call in Query Monitor plugin for object cache when there is no group stats.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@mae829 mae829 requested a review from a team as a code owner October 7, 2023 01:33
@rebeccahum rebeccahum added the [Component] Query Monitor ChangelogTagID: 226872528 label Oct 7, 2023
@rebeccahum rebeccahum merged commit 9ab1250 into Automattic:develop Oct 7, 2023
@mae829 mae829 deleted the fix/qm-object-cache-markup branch October 7, 2023 06:57
andrea-sdl pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants