Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HyperDB #4942

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update HyperDB #4942

merged 1 commit into from
Oct 16, 2023

Conversation

rebeccahum
Copy link
Contributor

Description

Pulls in Automattic/HyperDB#140

Changelog Description

Plugin Updated: HyperDB

We upgraded HyperDB to fix PHP error addslashes(): Passing null to parameter #1 ($string) of type string is deprecated

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review October 16, 2023 15:59
@rebeccahum rebeccahum requested a review from a team as a code owner October 16, 2023 15:59
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #4942 (d0f6b20) into develop (b2cc8b6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #4942   +/-   ##
==========================================
  Coverage      29.20%   29.20%           
  Complexity      4746     4746           
==========================================
  Files            278      278           
  Lines          20903    20903           
==========================================
  Hits            6105     6105           
  Misses         14798    14798           

@rebeccahum rebeccahum merged commit 6c6bec3 into develop Oct 16, 2023
37 of 41 checks passed
@rebeccahum rebeccahum deleted the update/hyperdb branch October 16, 2023 16:23
andrea-sdl pushed a commit that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants