-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CANTINA-953: Add vip_block_wp_mail
filter
#4975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccahum
changed the title
Add
CANTINA-953: Add Oct 25, 2023
vip_block_wp_mail
filtervip_block_wp_mail
filter
Codecov Report
@@ Coverage Diff @@
## develop #4975 +/- ##
=============================================
+ Coverage 28.48% 28.81% +0.33%
- Complexity 4742 4743 +1
=============================================
Files 278 278
Lines 20904 20907 +3
=============================================
+ Hits 5954 6025 +71
+ Misses 14950 14882 -68
|
rebeccahum
force-pushed
the
add/filter_vip_block_wp_mail
branch
from
October 25, 2023 19:23
f1e9943
to
7efe2b1
Compare
rebeccahum
added
[Status] Needs Review
[Status] In Progress
and removed
[Status] Needs Review
labels
Oct 25, 2023
rebeccahum
force-pushed
the
add/filter_vip_block_wp_mail
branch
from
October 25, 2023 20:36
09e0e82
to
4edc8ff
Compare
Add tests
rebeccahum
force-pushed
the
add/filter_vip_block_wp_mail
branch
from
October 25, 2023 20:42
4edc8ff
to
668bb68
Compare
rebeccahum
added
[Status] Needs Docs
Signal to Yoli the docs need to be updated
and removed
[Status] In Progress
labels
Oct 25, 2023
PHP 8.2 fix for dynamic property
rebeccahum
force-pushed
the
add/filter_vip_block_wp_mail
branch
from
October 25, 2023 20:59
c53d000
to
3bdd36e
Compare
WPprodigy
approved these changes
Oct 25, 2023
rebeccahum
removed
[Status] Needs Review
[Status] Needs Docs
Signal to Yoli the docs need to be updated
labels
Oct 25, 2023
github-actions
bot
added
[Status] Deployed to staging
[Status] Deployed to production
and removed
[Status] Deployed to staging
labels
Oct 31, 2023
There is a typo in the documentation here, can someone update this? It should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a filter
vip_block_wp_mail
which can be used on the application level in client-mu-plugins to disable email. However, the existing constantVIP_BLOCK_WP_MAIL
which is for VIP internal use will take precedence.Changelog Description
Filter Added: vip_block_wp_mail
New filter
vip_block_wp_mail
which can be used on the application level in client-mu-plugins to disable email.Pre-review checklist
Please make sure the items below have been covered before requesting a review:
Pre-deploy checklist
Steps to Test
add_filter( 'vip_block_wp_mail','__return_true );
in client-mu-plugins