Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry limit to the connection pilot #5098

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

WPprodigy
Copy link
Contributor

Starting tracking the amount of retries, and implement a retry limit.

Also tracking two different timestamps now instead of conflating the same one. failure_timestamp vs success_timestamp

@WPprodigy WPprodigy requested a review from a team as a code owner December 13, 2023 20:19
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0d8c597) 28.85% compared to head (a2f37bd) 28.81%.

Files Patch % Lines
...onnection-pilot/class-jetpack-connection-pilot.php 75.67% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5098      +/-   ##
=============================================
- Coverage      28.85%   28.81%   -0.04%     
- Complexity      4762     4767       +5     
=============================================
  Files            279      279              
  Lines          20995    21000       +5     
=============================================
- Hits            6058     6052       -6     
- Misses         14937    14948      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rinatkhaziev rinatkhaziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've discussed replacing $retry with $attempt for better clarity, but otherwise looks good.

@WPprodigy WPprodigy force-pushed the update/connection-pilot-retry-limit branch from 5ec681e to a2f37bd Compare December 13, 2023 22:28
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@WPprodigy WPprodigy merged commit b4dad7f into develop Dec 13, 2023
38 checks passed
@WPprodigy WPprodigy deleted the update/connection-pilot-retry-limit branch December 13, 2023 22:59
WPprodigy added a commit that referenced this pull request Dec 13, 2023
* Add retry limit to the connection pilot

* Track “failed attempts” rather than failed retries
WPprodigy added a commit that referenced this pull request Dec 13, 2023
* Add retry limit to the connection pilot

* Track “failed attempts” rather than failed retries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants