-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry limit to the connection pilot #5098
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #5098 +/- ##
=============================================
- Coverage 28.85% 28.81% -0.04%
- Complexity 4762 4767 +5
=============================================
Files 279 279
Lines 20995 21000 +5
=============================================
- Hits 6058 6052 -6
- Misses 14937 14948 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've discussed replacing $retry
with $attempt
for better clarity, but otherwise looks good.
5ec681e
to
a2f37bd
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
* Add retry limit to the connection pilot * Track “failed attempts” rather than failed retries
* Add retry limit to the connection pilot * Track “failed attempts” rather than failed retries
Starting tracking the amount of retries, and implement a retry limit.
Also tracking two different timestamps now instead of conflating the same one.
failure_timestamp
vssuccess_timestamp