Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate wpcom_vip_term_exists() #5100

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Dec 14, 2023

Description

Going to break #4983 up. Let's start with wpcom_vip_term_exists() because 99.9% is on WP 6.0+

Changelog Description

Function Updated: wpcom_vip_term_exists

Deprecate wpcom_vip_term_exists() because WP 6.0 now has caching in term_exists(). Please use core function instead.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review December 14, 2023 18:58
@rebeccahum rebeccahum requested a review from a team as a code owner December 14, 2023 18:58
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b4dad7f) 28.88% compared to head (a1588d9) 28.84%.

Files Patch % Lines
vip-helpers/vip-deprecated.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5100      +/-   ##
=============================================
- Coverage      28.88%   28.84%   -0.05%     
  Complexity      4767     4767              
=============================================
  Files            279      279              
  Lines          21012    20983      -29     
=============================================
- Hits            6070     6052      -18     
+ Misses         14942    14931      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rebeccahum rebeccahum merged commit 4e7fa74 into develop Dec 14, 2023
37 of 38 checks passed
@rebeccahum rebeccahum deleted the deprecate_wpcom_vip_term_exists branch December 14, 2023 20:48
rebeccahum added a commit that referenced this pull request Feb 1, 2024
* Deprecate `wpcom_vip_term_exists()`

* Add `function_exists()` check for non-atomic deploys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants