Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Search e2e tests #5106

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix Search e2e tests #5106

merged 2 commits into from
Dec 19, 2023

Conversation

rebeccahum
Copy link
Contributor

Description

Changelog Description

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rebeccahum rebeccahum merged commit 8a37fe7 into develop Dec 19, 2023
37 checks passed
@rebeccahum rebeccahum deleted the fix/search-e2e-again branch December 19, 2023 21:47
rebeccahum added a commit that referenced this pull request Feb 1, 2024
* Do not enter phone number because it is optional now

* Remove sessions due to state or timing conflict in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants