Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement platform-wide mitigation for wpcom-block-editor breakage #6047

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

rinatkhaziev
Copy link
Contributor

Description

Change in wpcom-block-editor external dependency resulted in broken Paragraph blocks if a site used <= Jetpack 13.6 and Core <= 6.5.

This is a hotfix disabling the functionality in question.

Changelog Description

Fixed

  • Mitigate paragraph block breakage wpcom-block-editor

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rinatkhaziev rinatkhaziev requested a review from a team as a code owner December 10, 2024 18:09
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 30.55%. Comparing base (c82dc65) to head (6799101).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vip-jetpack/vip-jetpack.php 52.38% 10 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6047      +/-   ##
=============================================
+ Coverage      30.51%   30.55%   +0.03%     
  Complexity      4811     4811              
=============================================
  Files            289      289              
  Lines          21181    21190       +9     
=============================================
+ Hits            6463     6474      +11     
+ Misses         14718    14716       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vip-jetpack/vip-jetpack.php Outdated Show resolved Hide resolved
vip-jetpack/vip-jetpack.php Outdated Show resolved Hide resolved
@rebeccahum rebeccahum merged commit 9634d8d into develop Dec 10, 2024
36 checks passed
@rebeccahum rebeccahum deleted the hotfix/jp-wpcom-block-editor branch December 10, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants