Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement is_complete for the square task #1486

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

moon0326
Copy link
Contributor

@moon0326 moon0326 commented Jun 12, 2024

Changes proposed in this Pull Request:

This PR implements is_complete function for the Square task.

The logic is copied from Square plugin's is_connected function.

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Create a new Square PAO site.
  2. SSH into the site and replace includes/tasks/class-wc-calypso-task-get-paid-with-square.php with the one included in this PR.
  3. Go to WooCommerce -> Home and click on Get paid with Square task.
  4. You can either sign up for Square or manually set wc_square_access_tokens option. I would recommend signing up a square account.
  5. Once you're redirected back to the site from Square, the task should be marked as completed.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Copy link

github-actions bot commented Jun 12, 2024

Size Change: 0 B

Total Size: 201 kB

ℹ️ View Unchanged
Filename Size
./build/53.js 1.08 kB
./build/index.css 878 B
./build/index.js 126 kB
./build/marketing.js 58.3 kB
./build/payment-gateway-suggestions.css 1.24 kB
./build/payment-gateway-suggestions.js 6.57 kB
./build/plugins.js 3.93 kB
./build/style-index.css 2.15 kB
./build/style-marketing.css 800 B

compressed-size-action

@moon0326 moon0326 marked this pull request as ready for review June 13, 2024 11:29
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CleanShot 2024-06-13 at 15 41 57@2x

@cpapazoglou cpapazoglou merged commit 4d780b3 into master Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants