feat: enable tokenized ECE by default #10016
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosso
requested review from
a team and
FangedParakeet
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
FangedParakeet
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Took me longer than I'd like to admit to realise that the ECE wouldn't show its face on my test site, because I'm currently out of the US in a country scorned by Stripe, and when finally fooling it into revealing itself with the help of a VPN, I am still unable to complete a checkout due to an external GPay error (on both tokenised and non-tokenised ECEs)...but the changes here look straightforward and sensible enough to me and I can proudly report that the tokenised cart code was summoned when the flag was enabled and forgotten when the snippet filter was in place.
LGTM. 
|
Holding off on this until I investigate this possible concern: paJDYF-g3R-p2#comment-27466 |
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9724
Changes proposed in this Pull Request
Enabling the tokenized ECE by default.
It can be disabled via a filter, until we remove the feature flag:
Important
I am planning to merge this after the release of WooPayments 8.8.0, so it can land in WooPayments 8.9.0.
Testing instructions
/wp-json/wc/store/v1/cart/add-item(for example)/?wc-ajax=wcpay_add_to_cart(for example) and no longer to the Store APInpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge