Fixes to multiple failing E2E tests #10057
Open
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
…duced by default on new sites in WooCommerce 9.6.
…ce the company field will no longer be shown by default in WooCommerce 9.6 or higher.
…d enable company field as an optional parameter.
6 tasks
alopezari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9746
Fixes #10115
Changes proposed in this Pull Request
This PR fixes the following failing E2E tests:
tests/e2e/specs/wcpay/merchant/merchant-payment-gateways-confirmation.spec.js:
These were failing because of wrong locator that seemed to have been outdated at some point.
tests/e2e/specs/wcpay/shopper/shopper-checkout-failures.spec.js:
Same as before, the tests were failing due to inaccurate locators.
tests/e2e/specs/wcpay/shopper/shopper-pay-for-order.spec.js:
Inaccurate locators again.
Shopper tests in WooCommerce Beta version:
WooCommerce 9.6 enables by default the Coming Soon mode for new sites, which breaks our tests. In order to bypass this, the script that sets up our test environment will deactivate this mode by disabling a flag in the Options table.
tests/e2e/specs/subscriptions/merchant/merchant-subscriptions-renew-action-scheduler.spec.js:
WooCommerce 9.6 adds a new logic to define which fields are shown by default in the checkout form, and the
companyfield from the billing section will now be hidden by default, unless you enable it. We've updated our test environment setup flow to enable thecompanyfield - used by our tests - in the checkout form by enabling a flag in the Options table.tests/e2e/specs/wcpay/shopper/shopper-multi-currency-widget.spec.js:
There seems to be a race condition here that make a test from this spec fail on CI but pass on my local environment, so I can't debug it properly. After spending some time with this one, I've decided to skip this test because it will be migrated soon and we don't need to spend some more extra time on it.
Testing instructions
merchant-payment-gateways-confirmationtests in headless mode withnpm run test:e2e tests/e2e/specs/wcpay/merchant/merchant-payment-gateways-confirmation.spec.js.merchant-payment-gateways-confirmationtests in UI mode withnpm run test:e2e-dev tests/e2e/specs/wcpay/merchant/merchant-payment-gateways-confirmation.spec.js.shopper-checkout-failurestests in headless mode withnpm run test:e2e tests/e2e/specs/wcpay/shopper/shopper-checkout-failures.spec.js.shopper-checkout-failurestests in UI mode withnpm run test:e2e-dev tests/e2e/specs/wcpay/shopper/shopper-checkout-failures.spec.js.shopper-pay-for-ordertests in headless mode withnpm run test:e2e tests/e2e/specs/wcpay/shopper/shopper-pay-for-order.spec.js.shopper-pay-for-ordertests in UI mode withnpm run test:e2e-dev tests/e2e/specs/wcpay/shopper/shopper-pay-for-order.spec.js.shopper-multi-currency-widgettests in headless mode withnpm run test:e2e tests/e2e/specs/wcpay/shopper/shopper-multi-currency-widget.spec.js.shopper-multi-currency-widgettests in UI mode withnpm run test:e2e-dev tests/e2e/specs/wcpay/shopper/shopper-multi-currency-widget.spec.js.npm run test:e2e-reset.E2E_WC_VERSION=betato yourlocal.envfile, this will configure your environment to use the latest WooCommerce Beta version.npm run test:e2e-setup.merchant-orders-status-changetests in headless mode withnpm run test:e2e tests/e2e/specs/wcpay/merchant/merchant-orders-status-change.spec.js.merchant-orders-status-changetests in UI mode withnpm run test:e2e-dev tests/e2e/specs/wcpay/merchant/merchant-orders-status-change.spec.js.merchant-subscriptions-renew-action-schedulertests in headless mode withnpm run test:e2e tests/e2e/specs/subscriptions/merchant/merchant-subscriptions-renew-action-scheduler.spec.js.merchant-subscriptions-renew-action-schedulertests in UI mode withnpm run test:e2e-dev tests/e2e/specs/subscriptions/merchant/merchant-subscriptions-renew-action-scheduler.spec.js.npm run test:e2e-resetand removingE2E_WC_VERSION=betafrom yourlocal.envfile.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge