Optimise memory usage when formatting logger entries #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
Comment on lines
+127
to
+137
| $formatted_lines = []; | ||
| $log_entry = array_shift( $entries ); | ||
| while ( null !== $log_entry ) { | ||
| foreach ( explode( "\n", $log_entry ) as $line ) { | ||
| $formatted_lines[] = $line_prefix . $line; | ||
| } | ||
| unset( $log_entry ); | ||
| $log_entry = array_shift( $entries ); | ||
| } | ||
|
|
||
| return implode( "\n", $formatted_lines ); |
There was a problem hiding this comment.
Personally, I prefer to avoid while loops if an iterator is available. In this case, a simple foreach loop should do the trick. Even if there is context here, the $entries array should be quite short, so this seems overoptimized, especially considering that array_shift will modify the array every time.
Suggested change
| $formatted_lines = []; | |
| $log_entry = array_shift( $entries ); | |
| while ( null !== $log_entry ) { | |
| foreach ( explode( "\n", $log_entry ) as $line ) { | |
| $formatted_lines[] = $line_prefix . $line; | |
| } | |
| unset( $log_entry ); | |
| $log_entry = array_shift( $entries ); | |
| } | |
| return implode( "\n", $formatted_lines ); | |
| $formatted_lines = []; | |
| foreach ( $entries as $log_entry ) { | |
| foreach ( explode( "\n", $log_entry ) as $line ) { | |
| $formatted_lines[] = $line_prefix . $line; | |
| } | |
| } | |
| return implode( "\n", $formatted_lines ); |
For me, the decreased number of anonymous functions created, combined with much fewer sprintf() calls, should be more than sufficient.
There was a problem hiding this comment.
foreach was my first choice. But I had to add an unset because I caught a memory overflow on my local setup when testing a complex transactions page. This eliminated the option of using foreach 😞
There was a problem hiding this comment.
Huh, could it be that you were still using sprintf() for the whole prefix? I'm really surprised that PHP would not collect the foreach() garbage. Anyhow, let's unblock others, we could experiment with this later.
RadoslavGeorgiev
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10201
Changes proposed in this Pull Request
Optimizations to the memory consumption when formatting a logger entry:
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge