-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert shopper-wc-blocks-saved-card-checkout-and-usage spec to Playwright #10223
Open
tpaksu
wants to merge
20
commits into
develop
Choose a base branch
from
dev/10075-playwright-migration-shopper-wc-blocks-saved-card-checkout-and-usage
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Convert shopper-wc-blocks-saved-card-checkout-and-usage spec to Playwright #10223
tpaksu
wants to merge
20
commits into
develop
from
dev/10075-playwright-migration-shopper-wc-blocks-saved-card-checkout-and-usage
+266
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eckout-purchase-with-upe-methods
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
Base automatically changed from
dev/10064-playwright-migration-shopper-checkout-purchase-with-upe-methods
to
develop
January 23, 2025 15:20
…-blocks-saved-card-checkout-and-usage
…-blocks-saved-card-checkout-and-usage
…-blocks-saved-card-checkout-and-usage
Added the necessary fixes to #10244 which will solve the errors on this branch, waiting for that to get merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10075
Changes proposed in this Pull Request
This PR ports the existing WC Block card saving, purchasing with the saved card, and deletion tests from Puppeteer to Playwright, and is based on #10203 which contains the saved card functions that handles the My Account > Payment methods workflows.
Also has some small tweaks like moving the assertion that checks for "Payment method deleted." string from the card delete function to the test bodies.
Testing instructions
npm run test:e2e-pw-ui checkout-and-usage
, watch the CheckoutWCB page creation, and expect all tests to pass.tests/e2e/config/local.env
and setSKIP_WC_BLOCKS_TESTS
to1
. Re-run the test above and check if all three tests are skipped.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge