Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow that runs only changed E2E tests, and succeeds when no tests have changed #10233

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

tpaksu
Copy link
Contributor

@tpaksu tpaksu commented Jan 24, 2025

Context: p1737719556299039-slack-C01B8KNUYSW

Changes proposed in this Pull Request

Testing instructions

This PR adds a workflow that runs only the modified E2E tests in it, helping us see the errors faster (~5-10 minutes) without waiting for all tests to complete (Which takes around 35-40 minutes to complete now, before optimizations). Also updates Playwright to 1.50, since the --only-changed option was added in v1.46, and we were using v1.43.


  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@botwoo

This comment was marked as off-topic.

This comment was marked as off-topic.

@tpaksu tpaksu marked this pull request as ready for review January 24, 2025 13:04
@tpaksu tpaksu requested a review from a team as a code owner January 24, 2025 13:04
@tpaksu tpaksu self-assigned this Jan 24, 2025
@tpaksu tpaksu added category: e2e Issues and PRs related to e2e tests. focus: devops Release processes, monitoring, automations, dev tools, CI/CD pipeline pr: needs review labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: e2e Issues and PRs related to e2e tests. focus: devops Release processes, monitoring, automations, dev tools, CI/CD pipeline pr: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants