fix: itemized totals & pending amount on tokenized cart #8916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +33 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
frosso
commented
Jun 6, 2024
| label: __( 'Tax', 'woocommerce-payments' ), | ||
| pending: true, |
There was a problem hiding this comment.
Removed pending to allow for the itemized amounts to be displayed - I checked the previous implementation, and they also weren't using it
There was a problem hiding this comment.
Out of curiosity: do we happen to know what the business value of the pending property is? Which state does it represent?
There was a problem hiding this comment.
It seems to be used by browsers to display things in different ways.
Stripe says:
If you might change this amount later (for example, after you have calcluated shipping costs), set this to true
In our case, it seems that pending: true will never be needed because there's always going to be an address selected on the Google Pay/Apple Pay modal. And if an address is selected, we'll also have the shipping options available from the Store API.
timur27
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
The changes are clear and test well. Thanks @frosso 🚀
The itemized amount should be displayed (click the info icon next to the price to see it on GPay - the info icon wasn't visible before)
Just to make sure I haven't misunderstood anything: the info icon next to the price appears for me on develop as well with variable products, but it doesn't have the itemized amount displayed.
| Header 1 | Header 2 |
|---|---|
 |
 |
Is your product a physical product, and do you have taxes setup and/or do you have shipping options? |
|
@frosso, I do have the shipping listed when selected 👍
I was just wondering whether the info icon was indeed not there on 
|
|
Per our quick chat, there was no info icon on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #8841
Changes proposed in this Pull Request
The itemized totals sometimes weren't displayed.
It turns out that the issue is with a combination of "pending" amount and wrong
parseInt.I was doing things like
if ( attribute ) {...parseInt(attribute, 10)}.The problem is that
if( '0' )(ifon string with0) returnstrue. Which makes sense.So I moved the
parseIntoutside of theif(...)check.Now the
ifcheck is checking for the parsed value. In case of0, it returns `false).Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge