Upgrade docker image to PHP 8.1 #9146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
alopezari
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Thanks for working on this @achyuthajoy!
I'm not able to run npm run test:php-coverage successfully locally, it results in failure after 2074 / 2190 ( 94%), and it seems it is consistent in my case. Did you check if it's working on your end?
Also, considering the docker container now runs on PHP 8.1, should we update the test matrix from the Coverage workflow to reflect this? As it still declares PHP 7.4:
https://github.com/Automattic/woocommerce-payments/blob/trunk/.github/workflows/coverage.yml#L20
alopezari
reviewed
Aug 30, 2024
@alopezari Works fine for me. 
|
@alopezari Sure we can update the matrix. But not for every workflow because we still want to support PHP 7.3 and above. |
Yes! I know. I only meant the matrix from the workflow I linked in my message because it only declares PHP 7.4 where the docker container is setting up 8.1. Actually that matrix only defines 1 PHP version so I think it's purpose is labelling instead of setting multiple configurations. |
Fixed in 0ee9afe |
achyuthajoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9092
Changes proposed in this Pull Request
Testing instructions
brew install [email protected]or using https://github.com/shivammathur/homebrew-php.npm installto install dependencies.npm run upto spin up docker containers with the new image.npm run clito connect to docker shell and runphp --versionto confirm the PHP version as 8.1npm run buildnpm run testnpm run test:php-coveragenpm run lint:phpnpm run psalmnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge