E2E: Fix the dispute save draft challenge failing due to redirect race condition #9284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
6 tasks
timur27
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Hey @Jinksi, I've been reviewing this PR and wanted to leave my feedback here as well. I think both PRs address the issue effectively, with your approach incorporating a bit more navigation, which adds some robustness, though it might take a few seconds longer. I'm happy to approve your PR—please share your thoughts so we can decide whether to merge Daniel's PR or yours. Thanks for fixing this 🚀
I like this solution better over what I implemented on #9275 as it seems more explicit on what it's doing. I'll close mine in favor of this. |
danielmx-dev
approved these changes
Aug 20, 2024
Thanks @danielmx-dev – My apologies for not spotting your PR earlier. It's a small difference either way, but I also prefer this PR's solution since it is closer to the merchant's flow: click save button → follow page redirect → navigate back to dispute details (in the future). |
|
Failing E2E Playwright tests are not related to this PR – checkout failures. |
|
All tests are now passing on E2E Tests - All for this branch – merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9281
Changes proposed in this Pull Request
This PR fixes the failing e2e test
Disputes > Merchant can save and resume draft dispute challengewhich is failing due to a redirect to the dispute list screen.Previously, this redirect was slow enough to allow the dispute details page refresh to occur beforehand.
I suspect an improvement in e2e environment performance is now causing the redirect to occur before the page refresh can, causing the test to check against the wrong screen (disputes list rather than dispute details). This e2e test first started failing alongside #9109, but it may just be a coincidence.
The fix in this PR will wait for the redirect to occur before navigating to the dispute details screen.
Testing instructions
E2E tests allDisputes > Merchant can save and resume draft dispute challengetests pass.wcpay - merchantworkflows and search formerchant-disputes-save-draft-challenge.spec.jsnpm run test:e2e-setupornpm run test:e2e-upif already setupnpm run test:e2e -- tests/e2e/specs/wcpay/merchant/merchant-disputes-*to run all merchant disputes testsnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge