Update Credit Card / Debit Card label to Cards #9769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -83 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
@gpressutto5 Feel free to add me as reviewer if/when this is ready since it's closely tied with #10005. |
gpressutto5
changed the base branch from
develop
to
add/9826-payment-methods-logos-component
mdmoore
reviewed
Jan 22, 2025
| @@ -39,7 +39,7 @@ public function __construct( $token_service ) { | |||
| */ | |||
| public function get_title( ?string $account_country = null, $payment_details = false ) { | |||
| if ( ! $payment_details ) { | |||
| return __( 'Credit card / debit card', 'woocommerce-payments' ); | |||
| return __( 'Cards', 'woocommerce-payments' ); | |||
There was a problem hiding this comment.
This also updates the payment method title in the order to Cards. Just double checking that this is desired?
mdmoore
merged commit 5d980b7
into
add/9826-payment-methods-logos-component
23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9660
Changes proposed in this Pull Request
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge