Track events: Fix tracking property when transferring domains (#95214)

* Track event when using own domain * Fix tracking property on start * Improve variable definition
Automattic · Oct 8, 2024 · f13628c · f13628c
1 parent 5206710
commit f13628c
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/client/landing/stepper/declarative-flow/onboarding.ts b/client/landing/stepper/declarative-flow/onboarding.ts
@@ -99,6 +99,7 @@ const onboarding: Flow = {
 					setRedirectedToUseMyDomain( false );
 					return navigate( 'plans' );
 				case 'use-my-domain':
+					setSignupDomainOrigin( SIGNUP_DOMAIN_ORIGIN.USE_YOUR_DOMAIN );
 					if ( providedDependencies?.mode && providedDependencies?.domain ) {
 						return navigate(
 							`use-my-domain?step=${ providedDependencies.mode }&initialQuery=${ providedDependencies.domain }`

diff --git a/client/landing/stepper/hooks/use-record-signup-complete.ts b/client/landing/stepper/hooks/use-record-signup-complete.ts
@@ -75,6 +75,18 @@ export const useRecordSignupComplete = ( flow: string | null ) => {
 				true
 			);
 		},
-		[ domainCartItem, flow, planCartItem, selectedDomain, siteCount, siteId, theme ]
+		[
+			domainCartItem,
+			flow,
+			isNewUser,
+			isNewishUser,
+			planCartItem,
+			selectedDomain,
+			signupDomainOrigin,
+			site?.slug,
+			siteCount,
+			siteId,
+			theme,
+		]
 	);
 };
diff --git a/client/signup/main.jsx b/client/signup/main.jsx
@@ -565,6 +565,12 @@ class Signup extends Component {
 		// but it's not recommended outside of this, hence the name toStepper. See Automattic/growth-foundations#72 for more context.
 		if ( ! dependencies.toStepper ) {
 			debug( 'Tracking signup completion.', debugProps );
+			const isMapping = domainItem && isDomainMapping( domainItem );
+			const isTransfer = domainItem && isDomainTransfer( domainItem );
+			const signupDomainOriginValue =
+				isTransfer || isMapping
+					? SIGNUP_DOMAIN_ORIGIN.USE_YOUR_DOMAIN
+					: signupDomainOrigin ?? SIGNUP_DOMAIN_ORIGIN.NOT_SET;
 
 			recordSignupComplete( {
 				flow: this.props.flowName,
@@ -582,9 +588,9 @@ class Signup extends Component {
 				intent,
 				startingPoint,
 				isBlankCanvas: isBlankCanvasDesign( dependencies.selectedDesign ),
-				isMapping: domainItem && isDomainMapping( domainItem ),
-				isTransfer: domainItem && isDomainTransfer( domainItem ),
-				signupDomainOrigin: signupDomainOrigin ?? SIGNUP_DOMAIN_ORIGIN.NOT_SET,
+				isMapping: isMapping,
+				isTransfer: isTransfer,
+				signupDomainOrigin: signupDomainOriginValue,
 			} );
 		}
 	};