Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic Themes: Duotone Filter missing on the live site for left, right and center-aligned images on Simple Sites #75805

Closed
jorpdesigns opened this issue Apr 16, 2023 · 8 comments
Labels
[Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Images [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@jorpdesigns
Copy link

jorpdesigns commented Apr 16, 2023

Quick summary

When an Image Block has the Duotone Filter applied, the colors appear on the backend but not on the frontend.

This only affects classic themes on Simple sites. Looks like the bug was recently introduced, as noted in 12242641-hc

Steps to reproduce

  1. Ensure the test site is using a Classic theme (e.g. Orvis).
  2. Create a page and add an Image Block.
  3. Important! Set the image alignment option to center, left or right.
  4. Click the Duotone Filter button in the block toolbar and set your preferred colors.
  5. Publish the page and view on the frontend.

What you expected to happen

The Duotone effect should appear on the frontend, similar to how it is shown in the Editor.

gn2ERf.png

What actually happened

The Duotone effect does not appear on the frontend.

QIWYyA.png

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple

Logs or notes

  • Reported in 12242641-hc. Follow-up ticket: 6199292-zen.
  • Could reproduce with these themes: Orvis, Business, Twenty Nineteen, Twenty Seventeen, Photos, Radcliffe 2
  • The filter worked fine after testing these Site Editing Themes: Blank Canvas, Hey, Archivo
  • The duotone filter may be applied via CSS as a workaround but this would only work with the Premium plan.
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues labels Apr 16, 2023
@github-actions
Copy link

github-actions bot commented Apr 16, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6199292-zen
  • 6252844-zen

@cuemarie
Copy link

Hey @jorpdesigns ! Just ran a quick check on this, and was not able to replicate the issue with Orvis, Twenty Nineteen, or Twenty Twenty. Tested on a brand new free site, as well as an older Premium Plan site:

Twenty Twenty
Markup on 2023-04-18 at 10:57:08

Orvis
9XnS9s.png

Orvis on Premium Plan Site
KMyrnf.png


Are there any other specific steps I can take to try to reproduce this?

@cuemarie cuemarie added [Pri] Normal Schedule for the next available opportuinity. [Status] Needs Author Reply and removed [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Apr 18, 2023
@jorpdesigns
Copy link
Author

jorpdesigns commented Apr 19, 2023

Hi @cuemarie ! Took a while to reproduce but I finally managed to crack it.

Looks like the bug only affects images with alignment set to left, right and center (for some reason). Images with alignments set to None, Wide and Full aren’t affected.

I will update the report title and steps to reproduce.

@jorpdesigns jorpdesigns changed the title Classic Themes: Duotone Filter missing on the front end for Simple Sites Classic Themes: Duotone Filter missing on the live site for left, right and center-aligned images on Simple Sites Apr 19, 2023
@cuemarie
Copy link

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated on Twenty Nineteen & Orvis

Screenshots/Recordings

Twenty Nineteen
Markup on 2023-04-19 at 12:29:34

Orvis

The working image shows the following CSS:

Markup on 2023-04-19 at 12:36:09

But the aligned image does not contain the filter parameter at all:

Markup on 2023-04-19 at 12:34:58

📌 ACTIONS

  • Assigned to Apex

@cuemarie cuemarie added Triaged To be used when issues have been triaged. Images and removed [Status] Needs Author Reply labels Apr 19, 2023
@hngdny
Copy link

hngdny commented May 2, 2023

Another report here 37361778-hc

Atomic site, using Seedlet theme.

Tested and can confirm same issue can be replicated (Duotone color not applied when alignment is "center")

@csabarakasz
Copy link

6252844 Setting the image to None did not solve the duotone issue here.

@cuemarie
Copy link

This looks like a duplicate of #78442 , but I'll retest before closing as the steps to repro are slightly different.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 31, 2023
@cuemarie
Copy link

Retested this - on a self-hosted site with Twenty Sixteen active, image blocks do not show the Duotone filter on the live site, no matter their alignment setting.

Screen.Capture.on.2023-08-31.at.14-43-58.mp4

In that case, I'm closing this issue as a duplicate of #78442, where we'll track further issues.

📌 ACTIONS

  • Closed as duplicate

@cuemarie cuemarie closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2023
@cuemarie cuemarie added the [Closed] Duplicate Duplicate of an existing issue. label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Duplicate Duplicate of an existing issue. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Images [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

4 participants