Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic Themes: Duotone filter not applied on live site #78442

Closed
cuemarie opened this issue Jun 20, 2023 · 18 comments
Closed

Classic Themes: Duotone filter not applied on live site #78442

cuemarie opened this issue Jun 20, 2023 · 18 comments
Assignees
@gikaragia
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Images [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. Needs retest Flagged for retesting by Quality Engineering [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@cuemarie
Copy link

cuemarie commented Jun 20, 2023 •
edited
Loading

2023-08-31 - reported anew in /gutenberg repo here: WordPress/gutenberg#54099

Quick summary

On sites using a classic theme, Duotone filters apply in the post editor, but don't appear on the live site

Steps to reproduce

  1. Activate a classic theme like Twenty Twenty
  2. Open a new post and add an image block
  3. Add a duotone filter
  4. Save and view the post

What you expected to happen

The duotone filter to appear just like in the editor.

What actually happened

No duotone is applied.

Editor
Markup on 2023-06-20 at 10:37:04

Live Site
Markup on 2023-06-20 at 10:38:26

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Tested on Atomic site, Firefox browser

Duotone worked as expected on same site using theme TT3
@cuemarie cuemarie added [Type] Bug [Pri] Normal Schedule for the next available opportuinity. User Report Images labels Jun 20, 2023
@cuemarie cuemarie mentioned this issue Jun 20, 2023
Closed
@cuemarie
Copy link
Author

Recent report from #74357 :

  • Chat: 6427916-zd-woothemes (Libre 2 theme)
  • Follow Up Ticket: 6428606-zd-woothemes

@github-actions
Copy link

github-actions bot commented Jun 20, 2023 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

  • 6427916-zen
  • 6428606-zen
  • 6473910-zen
  • 6752520-zen
  • 6259701-zen
  • 6199292-zen
  • 6252844-zen
  • 6545304-zen
  • 7123721-zen
  • 7225527-zen
  • 7197512-zen
  • 7293087-zen
  • 7714741-zen
  • 7814855-zen

@cuemarie
Copy link
Author

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated on simple, AT, and outside of WordPress.com. Also noticed that if I set up an image with Duotone on an FSE theme, then switch the theme to a Classic theme, the duotone I set up is lost. I have to set it up again, but this time it doesn't apply to the live site.

Screenshots/Recordings

Duotone settings while on FSE theme TT3:

JCfxZg.png

Returning to my post after switching to theme Twenty Twenty:

1dnG2u.mp4

Atomic Site:

  • Gutenberg: v16.0.0
  • Editing Toolkit: 3.68851

Simple site:

  • Gutenberg: v16.0.0
  • Editing Toolkit: 3.68851
  • WP AMP: 2.0.5
  • CoBlocks: 2.18.1-simple-rev.4

Self-Hosted:

Markup on 2023-06-20 at 10:56:06

Markup on 2023-06-20 at 10:56:36

Gutenberg v16.0.0 and no other plugins

📌 ACTIONS

  • Assigned to Non-Urgent
  • Added to ‘HE Cross-repo Watchlist’ project board

📌 Message to Author

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Platform] Simple Triaged To be used when issues have been triaged. labels Jun 20, 2023
@Greatdane
Copy link

Another; 6473910-zd-woothemes

@jamiepalatnik
Copy link

Another report: 6752520-zd-a8c
Morden theme.

Found these similar issues that it might be good to merge: Automattic/themes#7054
#75805

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 31, 2023
@cuemarie
Copy link
Author

cuemarie commented Aug 31, 2023 •
edited
Loading

Nice finds, @jamiepalatnik , thank you!

📌 ACTIONS

@cuemarie cuemarie mentioned this issue Aug 31, 2023
Closed
@cuemarie
Copy link
Author

cuemarie commented Aug 31, 2023 •
edited
Loading

Customer reports from Automattic/themes#7054 :

  • 6259701-zen [Dara]
  • 27843422-hc [Sequential]

This was referenced Aug 31, 2023
Closed
Closed
@cuemarie
Copy link
Author

cuemarie commented Aug 31, 2023 •
edited
Loading

Customer Reports from #75805 :

  • 6199292-zen - Simple, Theme: Orvis
  • 37361778-hc - Atomic, Theme: Seedlet
  • 6252844-zen - Atomic, Theme: Seedlet

@cuemarie
Copy link
Author

Retested and can still replicate this on a self-hosted site with Gutenberg 16.5.1 active and theme Twenty Sixteen.

rCwiKC.mp4

@cuemarie cuemarie moved this from Needs Triage to To Do in Automattic Prioritization: The One Board ™ Aug 31, 2023
@cuemarie cuemarie added [Feature] Post/Page Editor The editor for editing posts and pages. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Aug 31, 2023
@cuemarie cuemarie added the [Feature] Core Blocks Blocks that come with Gutenberg. label Aug 31, 2023
@cuemarie cuemarie mentioned this issue Aug 31, 2023
Closed
@cuemarie
Copy link
Author

cuemarie commented Aug 31, 2023 •
edited
Loading

📌 ACTIONS
Reported this anew in /gutenberg, here:

@janmckell
Copy link

Since this is still open, I'm adding this Ticket reference, as I don't see it added before:
6545304-zd-a8c
7123721-zd-a8c

@ckmccoy2
Copy link

I ran into another example of this issue:
7225527-zd-a8c

@ClassicRKR27
Copy link

Another example while using the Alves theme: 7197512-zd-a8c

@github-actions github-actions bot added the [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. label Oct 30, 2023
@cuemarie cuemarie moved this from Triaged to Needs Core/3rd Party Fix in Automattic Prioritization: The One Board ™ Oct 30, 2023
@CodeAllNightNDay
Copy link

Example here with Barnsbury theme: 7293087-zd-a8c

@cuemarie
Copy link
Author

WordPress/gutenberg#54099 was just fixed last week, so this should resolve soon. Will need a retest to confirm.

@cuemarie cuemarie added the Needs retest Flagged for retesting by Quality Engineering label Nov 30, 2023
@matticbot matticbot moved this from Needs Core/3rd Party Fix to Triaged in Automattic Prioritization: The One Board ™ Nov 30, 2023
@mahfuzurwp
Copy link

7714741-zen

@tvolpert
Copy link

7814855-zen

@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@gikaragia gikaragia self-assigned this Sep 3, 2024
@gikaragia
Copy link
Contributor

Core fix seems to be merged: WordPress/gutenberg#54778

Tried with themes 2016-2020 and it works.

@gikaragia gikaragia added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gikaragia gikaragia

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Images [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. Needs retest Flagged for retesting by Quality Engineering [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
10 participants
@Greatdane @cuemarie @jamiepalatnik @tvolpert @CodeAllNightNDay @ClassicRKR27 @gikaragia @mahfuzurwp @ckmccoy2 @janmckell