Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembler: Site preview zooms over 100% #85317

Closed
richtabor opened this issue Dec 14, 2023 · 7 comments
Closed

Assembler: Site preview zooms over 100% #85317

richtabor opened this issue Dec 14, 2023 · 7 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@richtabor
Copy link

richtabor commented Dec 14, 2023 •
edited
Loading

Description

Having the site preview scale past 100% makes the fonts and other elements seem quite distorted and very large. I would expect that the preview cannot scale past 100%, and instead would be centered in the available space.

Visuals

CleanShot 2023-12-14 at 14 50 20
@richtabor richtabor added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Pattern Assembler The tool for building off of blank canvas using patterns. labels Dec 14, 2023
@github-actions github-actions bot added the [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. label Dec 14, 2023
@richtabor richtabor mentioned this issue Dec 14, 2023
Closed
@autumnfjeld
Copy link
Contributor

This will be taken care of in #85123

@richtabor
Copy link
Author

This will be taken care of in #85123

The whole site preview is pulled over 100% its original size; not the zooming mechanism itself. We'd need to adapt a full stop on the scaling of the site frame, so that the contents are not scaled.

@lucasmendes-design
Copy link

The whole site preview is pulled over 100% its original size

Interesting, I didn't know that. Do you have an example? Like before and after?

@taipeicoder
Copy link
Contributor

When the viewport is wide enough, the preview can zoom beyond 100%:
Image

What @richtabor is proposing is to cap it at 100% and center it:
Image

@taipeicoder taipeicoder mentioned this issue Dec 28, 2023
Merged
7 tasks
@taipeicoder
Copy link
Contributor

taipeicoder commented Dec 28, 2023 •
edited
Loading

Proposing this PR #85820 cc: @autumnfjeld @lucasmendes-design @Automattic/lego

@liviopv
Copy link

liviopv commented Dec 28, 2023

📌 ACTIONS

  • Marking this as Triaged since Marvel/Lego is already working on it and there's a PR to fix.

@liviopv liviopv added [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Feature Group] Appearance & Themes Features related to the appearance of sites. and removed [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. labels Dec 28, 2023
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Dec 28, 2023
@autumnfjeld
Copy link
Contributor

Closing this #85820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Pattern Assembler The tool for building off of blank canvas using patterns. [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@taipeicoder @richtabor @autumnfjeld @liviopv @lucasmendes-design