Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: update zoom control #85123

Closed
autumnfjeld opened this issue Dec 12, 2023 · 11 comments
Closed

Assembler: update zoom control #85123

autumnfjeld opened this issue Dec 12, 2023 · 11 comments
Assignees

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Dec 12, 2023

Description

This work is for further iteration on the Assembler zoom control.

See P2 Assembler: Allow to zoom out the preview p9Jlb4-9vy-p2

CURRENT

Image

PROPOSED NEW DESIGN
Latest slack instructions from Matias and Lucas: p1703163840417879/1702589666.260559-slack-CRWCHQGUB
Figma Tv3pYqA3EcRfiXC31IxrXE-fi-2469:33385#653418774
Lucas says he needs to decide on icon, but dev work can start and icon could be suggested by dev. p1703164324378109/1702589666.260559-slack-CRWCHQGUB

image
Screen.Recording.2023-12-21.at.10.21.47.mov

Prior work

#83034

@Automattic/lego

@richtabor
Copy link

richtabor commented Dec 14, 2023

I'm curious if we even need this to be honest.

Why not set it to "50%" effectively (with no control available), so you can see the page as you're dropping in patterns and designing? I suspect this would help with the notion that folks expect to edit content as well. If the view is not 100%, the content does not seem as editable.

Forcing the scale would remove the need to fix #85317

Like this:

CleanShot 2023-12-14 at 14 49 32

@autumnfjeld
Copy link
Contributor Author

FYI: #85317

@autumnfjeld
Copy link
Contributor Author

cc: @lucasmendes-design see Rich's comments

@lucasmendes-design
Copy link

Now I understood what he meant. However, I still believe that users will not see a good portion of their sites on small screens. I may be wrong, but I need to see how this will be implemented and test it.

Wix has this feature, and if you check on small screens, if you add two/three patterns, the site will be hidden.

@richtabor
Copy link

You'd still be able to scroll fine, and with #85319 implemented, you'd always see the latest patterns viewed.

@taipeicoder
Copy link
Contributor

Seems that this is not quite dev-ready. @autumnfjeld should we move this to the Backlog or Up. Next?

@lucasmendes-design
Copy link

you'd still be able to scroll fine

Sure, but you will lose some details from the patterns, and we also have patterns with short heights, for example. Showing 100% is useful for many cases.

@arthur791004
Copy link
Contributor

arthur791004 commented Dec 19, 2023

FYI: Here is the metric, calypso_signup_pattern_assembler_large_preview_zoom_out_scale_change, for how people scale the large preview

image

@autumnfjeld
Copy link
Contributor Author

autumnfjeld commented Dec 19, 2023

@Automattic/lego I'm confirming that we are going with the design as stated in the issue description. We can continue discussions in early 2024 as needed, but the design here p9Jlb4-9vy-p2 is approved by Pablo & Lucas. We are going with version 2.

EDIT on 22 Dec: change of plans. See latest comments.

@autumnfjeld
Copy link
Contributor Author

@Automattic/lego I've updated the issue description due to this slack conversation, p1703165039233399/1702589666.260559-slack-CRWCHQGUB with Matias & Lucas. We are going with Version 1 from p9Jlb4-9vy-p2

@taipeicoder
Copy link
Contributor

Closing via #85787. Recording for reference:

Screen.Capture.on.2024-01-04.at.09-08-47.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants