Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] User did not get migration email after completing the assisted migration flow #94126

Closed
mpkelly opened this issue Sep 3, 2024 · 9 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Site Migration Features related to site migrations to WPcom Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Platform] Atomic [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mpkelly
Copy link
Contributor

mpkelly commented Sep 3, 2024

Quick summary

Initial report p1725073959936799-slack-C06PZC1RR5F

A user contacted support after waiting to receive an email about their assisted migration. On inspecting tracking, we found they had submitted two requests but did not produce a ZenDesk ticket on the backend. It is suspected an early exit check in submit_new_ticket failed and returned site_not_found, and this wasn't caught on the front end, which doesn't handle the response. This happened in the old migration API, but as init_automated_migration has a similar check, we created this ticket to avoid the same issue in the new API.

See Slack for further analysis and Tracks event log.

Steps to reproduce

It's not known how to reproduce this issue yet. It could be related to the user having a Jetpack-connected site.

What you expected to happen

A ticket should be created in ZenDesk for every issue.

What actually happened

No ZenDesk ticket was created for this migration.

Impact

One

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@mpkelly mpkelly added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Sep 3, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Sep 3, 2024
@mpkelly mpkelly added Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". and removed Needs triage Ticket needs to be triaged [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Sep 3, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Sep 3, 2024
@github-actions github-actions bot added [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues labels Sep 3, 2024
@mpkelly
Copy link
Contributor Author

mpkelly commented Sep 3, 2024

It seems there was another case but the issue appears to be only on the client. This conditinal check fails and no ticket was created:

// config.isEnabled( 'automated-migration/collect-credentials' )  = true
// isCredentialsSkipped = false

if ( ! config.isEnabled( 'automated-migration/collect-credentials' ) || isCredentialsSkipped ) {
	sendTicket( {
		locale,
		from_url: fromUrl,
		blog_url: siteSlug,
	} );
}

One thing to note is that I completed the flow in a support session and that may have affected the result.

More details and a video here p1725334011341529/1725073959.936799-slack-C06PZC1RR5F

@mpkelly
Copy link
Contributor Author

mpkelly commented Sep 3, 2024

Another report here 8684398-zd-a8c. I confirmed that wpcom_support_free_migration_request_click is in the Tracks event log for this user, but there is no ZenDesk ticket.

{'path': '/setup/site-migration/migrateMessage', 'environment': 'production', 'automated_migration': 'true', 'environment_id': 'production', 'site_count': '1', 'client': 'browser', 'site_plan_id': '1', 'vpw': '1668', 'skipped_credentials': 'false', 'vph': '923'}

This is the same payload as the case in the comment above.

Copy link

github-actions bot commented Sep 3, 2024

Support References

This comment is automatically generated. Please do not edit it.

@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Sep 3, 2024
@jartes jartes added [Feature] Site Migration Features related to site migrations to WPcom [Platform] Atomic and removed [Platform] Simple labels Sep 3, 2024
@m1r0
Copy link
Member

m1r0 commented Sep 12, 2024

@andres-blanco, to double check, did your PR fix the issue or it's just related?

@obenland
Copy link
Member

@markbiek @andres-blanco Did #94151 fix this bug?

@andres-blanco
Copy link
Contributor

@markbiek @andres-blanco Did #94151 fix this bug?

Since the PR addresses a fix for users who went through the flow while already having a plan, I would consider it a related PR rather than a direct fix. This is because the issue doesn't specify whether the affected users had a plan or not.

cc @m1r0

@daledupreez
Copy link
Contributor

I think that another cause of this issue was addressed by #94383. @valterlorran, would you agree with that assessment?

@daledupreez daledupreez added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Oct 2, 2024
@valterlorran
Copy link
Contributor

@daledupreez, thanks for pinging. Yes! By the time Mike tested it, it seemed he didn't see the credentials step, which would explain the broken ticket creation flow.

@daledupreez
Copy link
Contributor

OK, I think we can mark this as closed based on the two PRs that we shipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Site Migration Features related to site migrations to WPcom Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Platform] Atomic [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

7 participants