Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong redirect after how to migrate step #94151

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

andres-blanco
Copy link
Contributor

Related to #94126

Proposed Changes

Redirect to the credential collection step after a user with a plan selects the DIFM option on the HOW_TO_MIGRATE step.

Why are these changes being made?

This fixes a bug on the site-migration flow. If a user with a plan selected the option DIFM on the HOW_TO_MIGRATE step they got redirected to the /migrateMessage step. This is wrong, since we should be sending users to the credential collection step.

More context: p1725373567345639/1725364409.566409-slack-C0Q664T29

Testing Instructions

  1. Apply this diff or navigate to the calypso.live link below
  2. Navigate to /start
  3. Select a Business plan
  4. Select import as intent
  5. Go through the flow and select Do it for me on the How to migrate step
  6. Verify you are redirected to the credential collection step

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~25 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
site-migration-flow              +146 B  (+0.2%)      +13 B  (+0.1%)
hosted-site-migration-flow       +146 B  (+0.2%)      +12 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@andres-blanco andres-blanco requested a review from a team September 3, 2024 16:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/wrong-redirect-after-howto-step on your sandbox.

@andres-blanco andres-blanco merged commit 54af538 into trunk Sep 3, 2024
11 checks passed
@andres-blanco andres-blanco deleted the fix/wrong-redirect-after-howto-step branch September 3, 2024 18:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants