Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Bump i18n-calypso to 1.8.4 #19658

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Framework: Bump i18n-calypso to 1.8.4 #19658

merged 1 commit into from
Nov 21, 2017

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Nov 9, 2017 •
edited
Loading

For React 16 compat, see Automattic/interpolate-components#11 and Automattic/i18n-calypso#45.

To test:

  • Verify that Calypso still works.

@ockham ockham self-assigned this Nov 9, 2017
@ockham ockham requested a review from samouri November 9, 2017 23:12
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/i18n-calypso

@ockham ockham mentioned this pull request Nov 9, 2017
Closed
@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 9, 2017
@ockham ockham requested a review from gwwar November 9, 2017 23:17
@ockham ockham added [Status] In Progress and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 10, 2017
@ockham
Copy link
Contributor Author

ockham commented Nov 10, 2017

Seeing this in Reader:

image

but only there. Will check if it's incidental.

@ockham ockham mentioned this pull request Nov 18, 2017
Merged
@ockham
Copy link
Contributor Author

ockham commented Nov 18, 2017

Updated to reflect what really ended up in interpolate-components v1.1.1 (which doesn't include the code change that lead to the above error).

@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Nov 21, 2017
@ockham
Copy link
Contributor Author

ockham commented Nov 21, 2017

Updated to use now-published [email protected]. @samouri Care to 👍 ? 😄

@samouri
Copy link
Contributor

samouri commented Nov 21, 2017

testing...

@samouri samouri mentioned this pull request Nov 21, 2017
Merged
2 tasks
@ockham ockham merged commit 5d4508a into master Nov 21, 2017
@ockham ockham deleted the update/i18n-calypso branch November 21, 2017 19:10
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

@gwwar gwwar Awaiting requested review from gwwar

Assignees

@ockham ockham

Labels
Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ockham @matticbot @samouri