Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor Tracking: Fix insert_method property value #53457

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Site Editor Tracking: Fix insert_method property value #53457

merged 1 commit into from
Jun 8, 2021

Conversation

david-szabo97
Copy link
Contributor

@david-szabo97 david-szabo97 commented Jun 7, 2021 •
edited
Loading

Changes proposed in this Pull Request

  • Make sure header-inserter inserter method is recognized in the site editor too

Testing instructions

  • Follow steps to enable tracking debugging at PCYsg-nrf-p2
  • Open Site Editor, open the inserter sidebar and insert a block. Make sure insert_method is set header-inserter.
  • Open Post Editor, open the inserter sidebar and insert a block. Make sure insert_method is set header-inserter.

Fixes #53414

@david-szabo97 david-szabo97 self-assigned this Jun 7, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 7, 2021
@david-szabo97 david-szabo97 mentioned this pull request Jun 7, 2021
Closed
24 tasks
@matticbot
Copy link
Contributor

matticbot commented Jun 7, 2021 •
edited
Loading

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-7427
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-7427&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Addison-Stavlo
Addison-Stavlo approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a simple fix! 😁 Tested this out and everything now works as expected. 🎉

@david-szabo97 david-szabo97 merged commit 82c3e8c into trunk Jun 8, 2021
@david-szabo97 david-szabo97 deleted the fix/site-editor-tracking-insert-method branch June 8, 2021 11:02
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Addison-Stavlo Addison-Stavlo Addison-Stavlo approved these changes

@kurt213 kurt213 Awaiting requested review from kurt213

@ianstewart ianstewart Awaiting requested review from ianstewart

Assignees

@david-szabo97 david-szabo97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site Editor Stats - wrong inserter_method for inserting blocks via sidebar.
3 participants
@david-szabo97 @matticbot @Addison-Stavlo