Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor Tracking: Fix error caused by generalizing block variation tracking #53667

Merged

Conversation

david-szabo97
Copy link
Contributor

Changes proposed in this Pull Request

Testing instructions

  • Open a site that uses Gutenberg version earlier than 10.6.
  • Insert "Twitter" block, make sure it's inserted and no errors in the console.

Related to #53410

@david-szabo97 david-szabo97 self-assigned this Jun 14, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 14, 2021
@matticbot
Copy link
Contributor

matticbot commented Jun 14, 2021

@matticbot
Copy link
Contributor

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor fix/generalized-block-variation-tracking-undefined-error on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me, and isn't erroring on legacy Gutenberg sites. Thanks for fixing this! I should have checked for the function in the first place. 🤦‍♀️

@david-szabo97 david-szabo97 merged commit 4655d2e into trunk Jun 15, 2021
@david-szabo97 david-szabo97 deleted the fix/generalized-block-variation-tracking-undefined-error branch June 15, 2021 12:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants