Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Stats - add editor type tracking for block widgets editors #53789

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Editor Stats - add editor type tracking for block widgets editors #53789

merged 2 commits into from
Jun 18, 2021

Conversation

Addison-Stavlo
Copy link
Contributor

Changes proposed in this Pull Request

Adds support for widgets and customize-widgets as editor_type values in block editor tracking events.

Testing instructions

  • Test the new widgets editors in both the widgets editor and customizer->widgets editor as outlined here - p58i-axR-p2
  • Follow steps to enable tracking debugging PCYsg-nrf-p2
  • Add some blocks in the editors and verify that the editor_type appears as expected.

Related to #53410

@Addison-Stavlo Addison-Stavlo self-assigned this Jun 17, 2021
@matticbot
Copy link
Contributor

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-8303
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-8303&env=jetpack

@Addison-Stavlo Addison-Stavlo mentioned this pull request Jun 17, 2021
Closed
24 tasks
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 17, 2021
@Addison-Stavlo Addison-Stavlo requested a review from a team June 17, 2021 13:50
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor add/editor-type-tracking-for-block-widgets on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

Copons
Copons approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

david-szabo97
david-szabo97 approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@david-szabo97 david-szabo97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working for both editors! 🚢

@Addison-Stavlo Addison-Stavlo merged commit dfa7c86 into trunk Jun 18, 2021
@Addison-Stavlo Addison-Stavlo deleted the add/editor-type-tracking-for-block-widgets branch June 18, 2021 19:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-szabo97 david-szabo97 david-szabo97 approved these changes

@Copons Copons Copons approved these changes

Assignees

@Addison-Stavlo Addison-Stavlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Addison-Stavlo @matticbot @Copons @david-szabo97