Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Directory: Update links and statuses for approved directories #94022

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

vitozev
Copy link
Contributor

@vitozev vitozev commented Aug 29, 2024

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1007

Proposed Changes

This PR updates some existing verbiage and statuses to better communicate with agencies when their agency is approved for a specific partner directory.

Before After
image image

Testing Instructions

  • Open the Automattic for Agencies live link and visit the Partner Directory Link.
  • If your agency is approved for specific, verify that it's displayed correctly and the copy changes make sense, and also that the links to the directory and your directory listing are correct.
  • If you need to approve your agency, please make sure you disapprove it by removing the sticker after you are done.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@vitozev vitozev added the A4A label Aug 29, 2024
@vitozev vitozev requested a review from cleacos August 29, 2024 10:05
@vitozev vitozev self-assigned this Aug 29, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a-partner-directory-approved-links on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -294,11 +294,8 @@ const PartnerDirectoryDashboard = () => {
<div className="partner-directory-dashboard__completed-section">
<div className="partner-directory-dashboard__heading">
{ translate(
'Thank you! You’ll be notified when the partner directory is live.',
'Thank you! You’ll be notified when the partner directories are live.',
// todo: Once the partner directory are live use the copy below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha. I love that you (or someone) left comments for future changes. professional @vitozev

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// todo: Once the partner directory are live use the copy below:

That was the comment I left in... July ( wow...how time flies... )

@vitozev vitozev merged commit b723e6d into trunk Sep 2, 2024
14 of 15 checks passed
@vitozev vitozev deleted the update/a4a-partner-directory-approved-links branch September 2, 2024 07:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants