Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Add credentials step #94024

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Migration: Add credentials step #94024

merged 3 commits into from
Aug 29, 2024

Conversation

gabrielcaires
Copy link
Contributor

Proposed Changes

  • Add the new CREDENTIAL STEP on the migration flow

Testing Instructions

Scenario 1: No FROM information

  • Go to /setup/migration
  • Select WordPress
  • Make the upgrade and payment
  • On the Need a hand? select Do it for me
  • Check if you can see the credential screen instead
  • Fill the credentials
  • Click on continue.
  • Check if you reach the end of the flow
  • Check if a ticket was created.

Scenario 2: From is available

  • Go to /setup/migration?from=[WORDPRESS_SITE]
  • Make the upgrade and payment
  • On the Need a hand? select Do it for me
  • Check if you can see the credential screen instead
  • Check if the Site Address field was already populated.

Scenario 3: Skip
Follow all steps described in Scenario 1 until the step Tell us about your site.

  • Click on Skip, I need help providing access
  • Check if you can see the /migrateMessage step.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires marked this pull request as ready for review August 29, 2024 13:38
@gabrielcaires gabrielcaires added the [Feature] Site Migration Features related to site migrations to WPcom label Aug 29, 2024
@gabrielcaires gabrielcaires self-assigned this Aug 29, 2024
@gabrielcaires gabrielcaires requested a review from a team August 29, 2024 13:39
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
@gabrielcaires gabrielcaires requested a review from a team August 29, 2024 13:39
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/credentials-step on your sandbox.

@@ -266,6 +270,8 @@ const useCreateStepHandlers = ( navigate: Navigate< StepperStep[] >, flowObject:
);
},
},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matticbot
Copy link
Contributor

matticbot commented Aug 29, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~113 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
migration-flow       +324 B  (+0.5%)     +113 B  (+0.9%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the flow with and without URL and it behaves as expected

@gabrielcaires gabrielcaires merged commit ffa0ca1 into trunk Aug 29, 2024
11 checks passed
@gabrielcaires gabrielcaires deleted the add/credentials-step branch August 29, 2024 16:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Migration Features related to site migrations to WPcom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants