-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: Add credentials step #94024
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@@ -266,6 +270,8 @@ const useCreateStepHandlers = ( navigate: Navigate< StepperStep[] >, flowObject: | |||
); | |||
}, | |||
}, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~113 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through the flow with and without URL and it behaves as expected
Proposed Changes
Testing Instructions
Scenario 1: No FROM information
/setup/migration
WordPress
Need a hand?
selectDo it for me
Scenario 2: From is available
/setup/migration?from=[WORDPRESS_SITE]
Need a hand?
selectDo it for me
Scenario 3: Skip
Follow all steps described in Scenario 1 until the step
Tell us about your site.
Skip, I need help providing access
/migrateMessage
step.Pre-merge Checklist