Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites: hide header and tab navigation on mobile #94029

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Aug 29, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/8864

Proposed Changes

  • Hides the site management preview header and tabs when rendered in mobile app

Demo

Screen.Recording.2024-08-29.at.21.31.05.mov

Why are these changes being made?

  • Fix issue with navigation on mobile

Testing Instructions

  • Go to the /site-monitoring site management view for an atomic site
  • Confirm you see the header and tab navigation
Screenshot 2024-08-29 at 21 33 10 * Update the network user agent to use `wp-iphone` and refresh the page * Confirm the header and tab navigation is no longer rendered Screenshot 2024-08-29 at 21 35 03

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Aug 29, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/site-management-panel-mobile on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Aug 29, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~82 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
staging-site                      +91 B  (+0.0%)      +31 B  (+0.0%)
sites-dashboard                   +91 B  (+0.0%)      +31 B  (+0.0%)
site-monitoring                   +91 B  (+0.0%)      +31 B  (+0.0%)
site-logs                         +91 B  (+0.0%)      +31 B  (+0.0%)
hosting-features                  +91 B  (+0.0%)      +31 B  (+0.0%)
hosting                           +91 B  (+0.0%)      +31 B  (+0.0%)
github-deployments                +91 B  (+0.0%)      +31 B  (+0.0%)
a8c-for-agencies-sites            +91 B  (+0.0%)      +22 B  (+0.0%)
a8c-for-agencies-referrals        +91 B  (+0.0%)      +29 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@eoigal eoigal changed the title Sites: hide header and tab navaigation on mobile Sites: hide header and tab navigation on mobile Aug 29, 2024
@eoigal eoigal added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2024
Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set the user agent and the header and navigation are hidden. ✅

@eoigal eoigal merged commit 5cd5f4f into trunk Aug 30, 2024
13 checks passed
@eoigal eoigal deleted the update/site-management-panel-mobile branch August 30, 2024 17:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants