Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A Dev Sites: Refetch dev licenses count after creating a new dev site and other minor fixes #94032

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Aug 29, 2024

Proposed Changes

  • Refetch dev licenses count after creating a new dev site
  • Refetch random site name after creating a new site
  • Fix missing site creation modal on Overview page

Why are these changes being made?

pdDOJh-3Cl-p2

Testing Instructions

  • Apply this PR to your local
  • Run yarn start-a8c-for-agencies
  • Go to the Overview page
  • Click on Add Sites > Development Site
  • Create a new dev site
  • Click again on Add Sites
  • Verify if the count was updated (subtracting the new site)
  • Click again on the Development Site
  • The site name suggestion should be different
  • Perform regression tests on Site Creation, purchasing a license, and creating a site afterward

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp requested a review from a team August 29, 2024 17:32
@phcp phcp self-assigned this Aug 29, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a-minor-issues on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~276 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +736 B  (+0.0%)     +217 B  (+0.0%)
entry-main                  +736 B  (+0.0%)     +215 B  (+0.0%)
entry-subscriptions         +483 B  (+0.0%)     +156 B  (+0.0%)
entry-login                 +483 B  (+0.0%)     +156 B  (+0.0%)
entry-domains-landing       +483 B  (+0.1%)     +156 B  (+0.1%)
entry-browsehappy           +483 B  (+0.2%)     +156 B  (+0.3%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~21819 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
a8c-for-agencies-overview           +18227 B  (+3.9%)    +6069 B  (+4.1%)
a8c-for-agencies-sites               +2442 B  (+0.1%)    +2035 B  (+0.4%)
staging-site                           +66 B  (+0.0%)      +85 B  (+0.0%)
sites-dashboard                        +66 B  (+0.0%)      +85 B  (+0.0%)
site-monitoring                        +66 B  (+0.0%)      +85 B  (+0.0%)
site-logs                              +66 B  (+0.0%)      +85 B  (+0.0%)
plugins                                +66 B  (+0.0%)      -35 B  (-0.0%)
jetpack-cloud-plugin-management        +66 B  (+0.0%)      -35 B  (-0.0%)
jetpack-cloud-partner-portal           +66 B  (+0.0%)     +274 B  (+0.1%)
jetpack-cloud-agency-sites-v2          +66 B  (+0.0%)     +161 B  (+0.0%)
hosting-features                       +66 B  (+0.0%)      +85 B  (+0.0%)
hosting                                +66 B  (+0.0%)      +85 B  (+0.0%)
github-deployments                     +66 B  (+0.0%)      +85 B  (+0.0%)
a8c-for-agencies-referrals             -65 B  (-0.0%)     -133 B  (-0.1%)
a8c-for-agencies-client                -65 B  (-0.0%)      +78 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3 bytes added 📈 [gzipped])

name               parsed_size           gzip_size
async-load-design        +13 B  (+0.0%)       +3 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@phcp phcp merged commit ddab7fc into trunk Aug 29, 2024
14 checks passed
@phcp phcp deleted the fix/a4a-minor-issues branch August 29, 2024 20:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants