Dissalow adding ns*.wordpress.com as NS record

[StevenPartridge]

Internal bug: 978-gh-Automattic/nomado-issues

Proposed Changes

• Sets the Hosts field as 'invalid' if setting NS record to *.wordpress.com

Why are these changes being made?

• As a user, I should not be able to add NS records pointing to our nameservers.
• NS records pointing to ns?.wordpress.com doesn't make sense since we are hosting the root zone anyway
• Fixes a bug that results in a UI issue where the added NS record shows as Handled by WordPress.com and the user can't edit or delete them anymore

It makes the most sense to block <*>.wordpress.com

Discussed introducing validation checks in the API too, as well as additional output/guidance for the user, but it was determined to be unnessesary at the moment. Can open new tasks to for either if requested.

Testing Instructions

• Check out this branch and run
• Navigate to 'Add a New DNS Record'
  • http://calypso.localhost:3000/domains/manage/<your.domain>/add-dns-record/<your.domain>
• Specify 'NS' as the type
• Add any 'Name'
• Test different combinations for 'Hosts', the only disallowed Hosts would match <*>.wordpress.com NS server structure
  • ns.wordpress.com
  • Valid: ns1wordpress.com, ns1.anythingelse.com
  • Invalid: ns1337.wordpress.com, ns1.wordpress.com

not valid: ns1.wordpress.com
not valid: ns2.WoRdPrEsS.com
not valid: ns3.wordpress.com
not valid: nsone.wordpress.com
not valid: ns999999.wordpress.com
not valid: mysite.wordpress.com
not valid: *.wordpress.com

valid: ns1wordpress.com
valid: wordpress.com
valid: ns1.wardpress.com
valid: ns1.WoRdPrEsS.edu
valid: ns2.wordpress.org
valid: ns3.wordpress.co

Regexr.com

Screenshot from local dev:

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-1410951d9b5246bbea74cc9ca389e9740da6d341

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-1410951d9b5246bbea74cc9ca389e9740da6d341&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-1410951d9b5246bbea74cc9ca389e9740da6d341&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +109 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[delputnam]

This looks correct and works well for me. It prevents users from incorrectly adding NS records that they are unable to remove.