Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include coupon code as query param in stepper onboarding checkout #94046

Closed
wants to merge 1 commit into from

Conversation

briowill
Copy link
Contributor

@briowill briowill commented Aug 30, 2024

Proposed Changes

Coupons applied in Stepper Onboarding flow are not applied to final price in Checkout.
This PR applies the coupon code to the final price in Checkout

Testing Instructions

  1. Checkout branch
  2. Launch Stepper onboard flow and include a coupon code calypso.localhost:3000/setup/onboarding/?coupon={code}
  3. Complete onboard flow
  4. Discount seen at pricing page should be reflected in checkout total

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~20 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
onboarding-flow        +68 B  (+0.2%)      +20 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@briowill briowill self-assigned this Aug 30, 2024
@briowill
Copy link
Contributor Author

briowill commented Sep 2, 2024

Closing as not needed now p1724991591885219-slack-CV1BNGVCH

@briowill briowill closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants