Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A Dev Sites: Fix marketplaceType when referralBlogId is missing #94057

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Aug 30, 2024

Proposed Changes

  • Fix marketplaceType when referralBlogId is missing. When setting defaultMarketplaceType the Checkout component gives priority to the param, so we need to set it to undefined when there is no referralBlogId.

Why are these changes being made?

pdDOJh-3Cl-p2

Testing Instructions

  • Apply this PR to your local
  • Go to http://agencies.localhost:3000/referrals/dashboard
  • Click on New Referral
  • Add products to the cart
  • Click on the cart icon and then Checkout
  • You should see the Referral Checkout page with the correct products in the cart
  • Submit the referral and verify if the email is correct
  • Regression test, try a referral for a dev site

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp requested a review from a team August 30, 2024 09:26
@phcp phcp self-assigned this Aug 30, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a-referral-checkout on your sandbox.

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change looks good and works as expected. 👌🏼 I did not observe any regressions.

@phcp phcp merged commit f8506fd into trunk Aug 30, 2024
15 checks passed
@phcp phcp deleted the fix/a4a-referral-checkout branch August 30, 2024 10:05
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants