Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Add new floating feedback panel #94129

Merged
merged 30 commits into from
Sep 3, 2024
Merged

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Sep 3, 2024

Related:

https://github.com/Automattic/red-team/issues/154

Proposed Changes

Adds a new floating feedback panel to the Traffic page.

Does not implement button behaviours (although hooks are in place for this and for tracks) nor does it intelligently display the panel. It can be dismissed but it will reappear on each render cycle. Button behaviours, tracks, and controlled display will be addressed in separate issues.

SCR-20240903-paak

Why are these changes being made?

Part of the User Feedback project.

pejTkB-1Ce-p2

Testing Instructions

  • Launch the Calypso Live site.
  • Visit the Traffic page.
  • Enable the feature flag: ?flags=stats/user-feedback
  • Confirm the floating panel is visible at the bottom of the window (not the page).
  • Confirm it displays correctly when scrolling or resizing the view.
  • Confirm the dismiss button works.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@a8ck3n a8ck3n self-assigned this Sep 3, 2024
@a8ck3n a8ck3n added the [Feature] Stats Everything related to our analytics product at /stats/ label Sep 3, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~167 bytes added 📈 [gzipped])

name   parsed_size           gzip_size
stats       +694 B  (+0.1%)     +167 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/stats-new-feedback-panel on your sandbox.

@a8ck3n a8ck3n marked this pull request as ready for review September 3, 2024 08:15
@a8ck3n a8ck3n requested a review from a team September 3, 2024 09:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
Copy link
Contributor

@dognose24 dognose24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! However, a few styles differ from the design as my comments. Could we align with the design as much as we can?

截圖 2024-09-03 下午10 57 04

client/my-sites/stats/feedback/style.scss Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
client/my-sites/stats/feedback/style.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@kangzj kangzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Nice work 🚀

@kangzj kangzj merged commit 49c2e2e into trunk Sep 3, 2024
11 checks passed
@kangzj kangzj deleted the update/stats-new-feedback-panel branch September 3, 2024 23:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 3, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16634092

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @a8ck3n for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 8, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants