-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Add new floating feedback panel #94129
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~167 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Dognose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Nice work 🚀
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16634092 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @a8ck3n for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related:
https://github.com/Automattic/red-team/issues/154
Proposed Changes
Adds a new floating feedback panel to the Traffic page.
Does not implement button behaviours (although hooks are in place for this and for tracks) nor does it intelligently display the panel. It can be dismissed but it will reappear on each render cycle. Button behaviours, tracks, and controlled display will be addressed in separate issues.
Why are these changes being made?
Part of the User Feedback project.
pejTkB-1Ce-p2
Testing Instructions
?flags=stats/user-feedback
Pre-merge Checklist