Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site setup: update image and text #94135

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Site setup: update image and text #94135

merged 1 commit into from
Sep 3, 2024

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented Sep 3, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/8872

Proposed Changes

  • Updates image and text used in design choice step in site setup flow

Before

Screenshot 2024-09-03 at 11 19 19

After

Screenshot 2024-09-03 at 11 37 36

Why are these changes being made?

  • Logical flows project

Testing Instructions

  • Create a test site
  • Choose Promote myself or business site goal
Screenshot 2024-09-03 at 11 40 17 * Confirm new image and text look ok

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@eoigal eoigal added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/design-choice on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~64 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
themes            -190 B  (-0.0%)      -33 B  (-0.0%)
marketplace       -190 B  (-0.0%)      -31 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~33 bytes removed 📉 [gzipped])

name                                     parsed_size           gzip_size
async-load-signup-steps-theme-selection       -190 B  (-0.1%)      -33 B  (-0.0%)
async-load-design-blocks                      -190 B  (-0.0%)      -33 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eoigal eoigal merged commit 3391dd4 into trunk Sep 3, 2024
13 checks passed
@eoigal eoigal deleted the update/design-choice branch September 3, 2024 14:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 3, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 3, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16631090

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @eoigal for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 8, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants