-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Update color themes to use WordPress blue colors #94147
Checkout: Update color themes to use WordPress blue colors #94147
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~15 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~34 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go once #94148 is merged. Let's not merge it before then, so as to not introduce another blue to our primary flows (Checkout currently matches Signup and Stepper, but not Calypso or Sites Dashboard).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update. This PR is good to go.
We'll need to make a subsequent update that updates the blue for the following:
- All text links should have the new blue (In terms, the support link, and edit button)
- The title for the callout in the sidebar
- The active state for the dropdown options in the term
- The borders for the payment methods (both hover and active state)
Also, unrelated, I noticed the borders between the payment method have a rounded edge on them when unselected:
@fditrapani thanks! I'm working on this in #94194 |
Background
I was researching why the buttons in checkout are a different shade of blue than other parts of calypso.
For example, see the color difference between these two buttons:
It turns out that checkout is using the color directly from the
@automattic/color-studio
package (which is outdated as version 2.6 everywhere in calypso) but some parts of calypso are using the deprecated button in the @automattic/components package which has a hard-coded color (from the@automattic/calypso-color-schemes
package) that happens to match the one in color-studio 3.0. In #94148 I'm updating all of calypso to use the latest version of the color-studio package.However, checkout currently uses the color
Blue 50
for its buttons, and the blue used by the "correct" color scheme is actuallyWordPress Blue 50
. So to get the correct color in checkout we need to also update the@automattic/composite-checkout
package to be useWordPress Blue
instead.Proposed changes
In this PR I'm updating the colors used by the
@automattic/composite-checkout
package theme (and the Jetpack variant) to use "WordPress Blue" instead of "Blue".Screenshot
This change by itself:
With #94148 also applied:
Testing Instructions
#006088
(previously#0675c4
).#3858e9
.