-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A Dev Sites: Add Allow clients to use the WordPress.com Help Center and hosting features setting
(is_fully_managed_agency_site
) toggle
#94150
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Allow clients to use the WordPress.com Help Center and hosting features setting
(is_fully_managed_agency_site
) toggle
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~490 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚢
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16654224 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16654224 Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related to https://github.com/Automattic/dotcom-forge/issues/8922.
Proposed Changes
A4AFullyManagedSiteSetting
component and related togglehandleToggle
function for related unit testsWhy are these changes being made?
This PR is part of the Free A4A Development Sites project: pdDOJh-3Cl-p2.
Testing Instructions
We will need to test the changes with different kind of sites:
http://calypso.localhost:3000/settings/general/{site-slug}?flags=a4a-dev-sites
. Please note the feature flag.is_fully_managed_agency_site
setting / blog option.You can also create a new WPCOM agency site (or dev site) and check whether the
is_fully_managed_agency_site
setting is correctly reflected in the toggle.Pre-merge Checklist