Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A Dev Sites: Add Allow clients to use the WordPress.com Help Center and hosting features setting (is_fully_managed_agency_site) toggle #94150

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Sep 3, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8922.

Proposed Changes

  • introduce A4AFullyManagedSiteSetting component and related toggle
  • mock handleToggle function for related unit tests

Markup on 2024-09-04 at 12:04:28

Why are these changes being made?

This PR is part of the Free A4A Development Sites project: pdDOJh-3Cl-p2.

Testing Instructions

We will need to test the changes with different kind of sites:

  • Simple site
  • Atomic agency site
  • Atomic agency dev site
  • Atomic non-agency site
  • Jetpack-connected site

  1. Check out this PR and build the app.
  2. When testing with Atomic or Jetpack sites, install the Jetpack Beta Tester plugin and checkout the latest Jetpack trunk. Related PR: Site Settings API: Include is_fully_managed_agency site option jetpack#39223.
  3. Navigate to the General Settings in Calypso at http://calypso.localhost:3000/settings/general/{site-slug}?flags=a4a-dev-sites. Please note the feature flag.
  4. When testing with Atomic agency sites, there's should be a new toggle (as can be seen in the screenshot above) - unless the site is a free dev site.
  5. If the toggle is displayed, it should be fully operational and change the is_fully_managed_agency_site setting / blog option.
  6. If the site a dev site, the toggle shouldn't be available, but an explanation text should be displayed instead.
  7. The toggle should not be available on other sites (e.g. Simple sites, Jetpack-connected sites).

You can also create a new WPCOM agency site (or dev site) and check whether the is_fully_managed_agency_site setting is correctly reflected in the toggle.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger changed the title Add placeholder toggle component A4A Dev Sites: Add Allow clients to use the WordPress.com Help Center and hosting features setting (is_fully_managed_agency_site) toggle Sep 3, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 3, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~490 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
settings      +1709 B  (+0.2%)     +490 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ivan-ottinger ivan-ottinger marked this pull request as ready for review September 4, 2024 09:36
@matticbot
Copy link
Contributor

matticbot commented Sep 4, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/a4a-dev-sites-fully-managed-toggle on your sandbox.

@ivan-ottinger ivan-ottinger requested a review from a team September 4, 2024 10:44
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 4, 2024
Copy link
Contributor

@mashikag mashikag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚢

@ivan-ottinger ivan-ottinger merged commit 3a8b596 into trunk Sep 6, 2024
14 checks passed
@ivan-ottinger ivan-ottinger deleted the add/a4a-dev-sites-fully-managed-toggle branch September 6, 2024 08:21
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 6, 2024
@a8ci18n
Copy link

a8ci18n commented Sep 6, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16654224

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 9, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/16654224

Thank you @ivan-ottinger for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 20, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants